Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove third interlock situation #135

Merged
merged 3 commits into from
Jan 6, 2024
Merged

remove third interlock situation #135

merged 3 commits into from
Jan 6, 2024

Conversation

dirixmjm
Copy link
Contributor

@dirixmjm dirixmjm commented Jan 5, 2024

When hour_rollover had started, push to get history_rollover started as well.
And bump to b6 release version

When hour_rollover had started, push to get history_rollover started as well.
@dirixmjm dirixmjm requested a review from a team as a code owner January 5, 2024 12:00
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (206ecfa) 34.80% compared to head (7b8fc2f) 34.80%.

Files Patch % Lines
plugwise_usb/nodes/circle.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   34.80%   34.80%           
=======================================
  Files          21       21           
  Lines        2428     2428           
=======================================
  Hits          845      845           
  Misses       1583     1583           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We can no longer assume we have the full 48 hours available when we only collect back todays and yesterdays hours.
Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections!

Copy link

sonarcloud bot commented Jan 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dirixmjm dirixmjm merged commit d21633e into main Jan 6, 2024
30 of 31 checks passed
@dirixmjm dirixmjm deleted the mdi branch January 6, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants