USB energy refactor #125

brefra · 2022-01-21T20:51:54Z

Merging into release-0.15.7 branch to build intermediate release 15.8

Improved timeout message handling based on response messages of USB-stick
More frequent energy monitoring polling when Stick is idle
Full rewrite of energy collection code. No dependency to fixed log interval. This should fix
- [BUG] Problems with Plugwise beta plugwise_usb-beta#5
- [BUG] Not all entities of a Circle seem to have valid values yet. plugwise_usb-beta#7
Added ability to change energy log interval
Better support for energy production #39

based on NodeResponse or NodeAckResponse messages

To support restructure of StickMessageController class

Don't rely on predicted seq_id but on actual response of stick

and do a regular Ping to detect when node is back on-line

- move energy related code to energy.py - make energy not depended to fixed (hour) log interval - allow changing of log interval - make energy collection more flexible to use

codecov · 2022-01-21T21:12:01Z

Codecov Report

❗ No coverage uploaded for pull request base (release-0.15.7@71e86f5). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             release-0.15.7      plugwise/python-plugwise#125   +/-   ##
==================================================
  Coverage                  ?   100.00%           
==================================================
  Files                     ?         6           
  Lines                     ?      2068           
  Branches                  ?         0           
==================================================
  Hits                      ?      2068           
  Misses                    ?         0           
  Partials                  ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e86f5...8c959c1. Read the comment docs.

brefra added 30 commits January 21, 2022 21:33

Rename NodeResponse into USBresponse

45d402f

Rename NodeAckSmallResponse into StickResponse

f8ae23a

Rename NodeAckLargeResponse into NodeResponse

1fbd659

Make message priority an Enum

ed6d68c

Use UTC time in controller

89b2757

Rename NodeRequest into PlugwiseRequest

d584717

Rename USBresponse into PlugwiseResponse

e7524db

Rename NodeJoinAckResponse into NodeRejoinResponse

0cd55f7

Make timestamp messages timezone aware

2e63931

Add Enums of message response types

331422d

Add message priority enum

628e1e3

Apply consistency to message process methods

09a3b6e

Make use of super() for message handling at node classes

6a0b7ce

Apply consistency to message process methods

9b42876

Make callbacks local to node classes

42cc62a

based on NodeResponse or NodeAckResponse messages

Cleanup and correction of imports

e190282

Add NodeRejoinResponse to sed

90ab06b

Move all actions to _process methods

9b1aa3e

Refactor message_processor method of Stick class

85f2114

Add local callbacks to stick class

4904c4f

Add logging for non processed message reponses

9c2a194

Move non validated response types to response.py

0540cb6

Add missing future imports

5aa8253

Correct callback leftovers

283e4ac

Make datetime timezone aware

7ff1b60

Remove duplicate decode

fd0487d

Apply some code formatting

3cfa227

Add addtional properties to PlugwiseRequest class

ae11b1c

To support restructure of StickMessageController class

Rewrite StickMessageController

c8bf278

Don't rely on predicted seq_id but on actual response of stick

Move retry & priority to PlugwiseRequest class

55a4530

brefra and others added 27 commits January 21, 2022 21:33

Mark power nodes unavailable after 5 minutes

a02be82

and do a regular Ping to detect when node is back on-line

Rename _request_info into _request_NodeInfo

90908a6

Rename _request_ping into _request_NodePing

b288baf

Add more typing

0dcda2a

Make features extendable

fc744d1

Update typing & comments to request and response

8342dd4

Full rewrite of energy

42216df

- move energy related code to energy.py - make energy not depended to fixed (hour) log interval - allow changing of log interval - make energy collection more flexible to use

Add missing MESSAGE_RETRY import

98ae0b1

Reorder and cleanup do... methods

c29823c

Guard for none discovered node

4767867

Correct comments

2f24347

Cleanup logging

91f80b9

Fix mac validation at response messages

d019e8a

Remove duplicate logging

f7c0f99

Apply formatting to CHANGELOG.md

a93cbe0

Update CHANGELOG.md

6e44a19

fixup: USB_energy_refactor Python code reformatted using Black

2600a9b

Change logging to debug for expected timeouts

8f69769

Revert accidentally unrelated committed code

401294f

Apply codespell

fbef2d8

Fix processing and logging of "drop_at_timeout" requests

53f250b

Fix collecting missing production logs

efebeb7

Remove unused node state

0613815

fixup: USB_energy_refactor Python code reformatted using Black

966216c

Bump to 0.15.8

dd90916

Update CHANGELOG.md

108e9da

Refix

8c959c1

brefra merged commit 972b11d into release-0.15.7 Jan 21, 2022

brefra deleted the USB_energy_refact-based_on_15.7 branch January 21, 2022 21:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

USB energy refactor #125

USB energy refactor #125

brefra commented Jan 21, 2022

codecov bot commented Jan 21, 2022

USB energy refactor #125

USB energy refactor #125

Conversation

brefra commented Jan 21, 2022

codecov bot commented Jan 21, 2022

Codecov Report