Fix bug for battery powered devices & attempt to fix memory leak #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main plugwise/plugwise-beta#271 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 2663 2663
=========================================
Hits 2663 2663 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bouwew
approved these changes
Feb 8, 2023
|
I'll create a plugwise-beta test-release first. |
|
Memory leak doesn't look to be fixed: https://community.home-assistant.io/t/plugwise-core-and-custom-component/236250/323 |
|
@brefra are there any more changes coming? If not, should we merge and release this update? |
|
Let's release to get this improvement out to more users. |
|
See python-plugwise/pyproject.toml Line 170 in 28e2aaa |
Prevent sending request for fully known memory addresses
bouwew
force-pushed
the
fix_memory_leak
branch
from
a8c389c
to
ab54da1
Compare
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix potential crash of submit thread when queued message of SED (battery powered devices) are send.
Attempt to fix memory leak reported at plugwise/plugwise_usb-beta#10 by introducing thread locking.
My setup, running this change, is stable for two day's now so looks promising....