Typed vector and tensor #1092
Typed vector and tensor #1092
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/tools/Tensor.h
Outdated
| /* between RVO and compile time this should be faster, but slows down openACC, a lot | ||
| template <typename T, unsigned i, unsigned j, unsigned m> | ||
| void external_rec(T*const out,const T*const v1, const T*const v2){ | ||
| if constexpr (j>0) { | ||
| external_rec<i,j-1,m>(out,v1,v2); | ||
| } else if constexpr (i>0) { | ||
| external_rec<i-1,m-1,m>(out,v1,v2); | ||
| } | ||
| out[i*m+j]=v1[i]*v2[j]; | ||
| } | ||
|
|
||
| template<typename T, unsigned n, unsigned m> | ||
| std::array<T,n*m> externaProd(const VectorGeneric<T,n>&v1,const VectorGeneric<T,m>&v2){ | ||
| std::array<T,n*m> toRet; | ||
| external_rec<n-1,m-1,m>(toRet.data(),v1.data(),v2.data()); | ||
| return toRet; | ||
| } | ||
|
|
||
| template<typename T, unsigned n, unsigned m> | ||
| TensorGeneric<T,n,m>::TensorGeneric(const VectorGeneric<T,n>&v1,const VectorGeneric<T,m>&v2) | ||
| :d(externaProd(v1,v2)) {} | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
|
Quick note, replace |
Iximiel
force-pushed
the
typedVectorandTensor
branch
from
1b33393 to
0e3a8d9
Compare
I force-pushed to align with existing code, and to have clearer commits I have to set up a few benchmarks and redo the documentation, to keep the not-member functions in the wanted pages |
| template<typename... Args> | ||
| void TensorGeneric<n,m>::auxiliaryConstructor(double first,Args... arg) | ||
| void TensorTyped<T,n,m>::auxiliaryConstructor(T first,Args... arg) |
Check notice
Code scanning / CodeQL
Unused static variable Note
| template<typename... Args> | ||
| void VectorGeneric<n>::auxiliaryConstructor(double first,Args... arg) | ||
| void VectorTyped<T, n>::auxiliaryConstructor(T first,Args... arg) |
Check notice
Code scanning / CodeQL
Unused static variable Note
Description
I started to work on this in the context of #1076 and in sync with what I did with #1075.
My idea was to set up some types of plumed to be more flexible and usable in contexts like sycl, cuda, openACC or targetted openMP. Then I dropped this for a while, but I thought it could be interesting to bring it out again.
Most of the problems this new approach gives are in the friend functions within the vector and the tensor, they give strange warnings. I think due to the fact that I am declaring friend functions like
template<typename U, unsigned m> U dotProduct(const VectorGeneric<U, m>&,const VectorGeneric<U, m>&);to atemplate<typename T, unsigned n> VectorGeneric<T, n>, with all types and all dimensions. On one hand, I do not think is a problem, but on the other hand, it does make me a little uncomfortable.If I understood correctly those functions are declared friend to appear in the documentation page of Tensor/Vector, maybe by putting
\ingroup TOOLBOXin their docstring they will appear in the toolbox, or in another doxygen module and we can remove the friend declarations.In any case the part with the friend-declared functions must be finished because I applied two different approaches in Vector and Tensor: in tensor, I eliminated the friend nearly all the friend declarations because I was having an hard time in trying to compile with all of them.
I also added a
.data()method to access the underline array in both classes. This new method should be used in place of the various&variable[0]to get the pointer to the first element of the array. But as now, I did not refactored it in the code (but I am using something similar in #1075 ).Target release
I would like my code to appear in release 2.10
Type of contribution?
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests