Proposing: compacting lower and upper walls into a single file #1112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the context of the WALLS, I compacted Uwalls and Lwalls into a single file (without the update of the documentation from #1111, but with the code correction)
The idea is to remove the repetition (there are only 17 different lines in two files of 158 and 157 lines, which should work in a mirrored way) and get to debug\update a single file.
Then I would like to port something similar also for the non-scalar version of the walls since I think it could bring advantages (no jit and compile-time optimizations and less cache misses).
And since the code itself would be the very same maybe compact also the non-scalar variant into a single one.
What do you think?
This is a
constexpr
solution, so to back-port it will lose some of it "slimness".Target release
I would like my code to appear in release ???
Type of contribution
Copyright
COPYRIGHT
file with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulename
in order to make sure the headers of the module are correct.Tests