Convert to having the EIP_MANAGEMENT variable as part of the packetcluster Type #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidspek
reviewed
May 6, 2022
| @@ -55,6 +62,7 @@ patches: | |||
| --interface "lo" \ | |||
| --vip "{{ .controlPlaneEndpoint }}" \ | |||
| --controlplane \ | |||
| --services \ | |||
There was a problem hiding this comment.
I don't think services will work here, at least not last time I tried it. From what I experience and based on the kube-vip docs we'll actually need to run kube-vip as a daemonset on the worker nodes for service load balancers.
davidspek
reviewed
May 6, 2022
api/v1beta1/packetcluster_types.go
Outdated
|
|
||
| // EIPManagement represents whether this cluster uses CPEM or kube-vip to | ||
| // manage its vip for the api server IP | ||
| EipManagement string `json:"eipmanagement"` |
There was a problem hiding this comment.
The webhook should be updated so that this field is immutable.
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
davidspek
reviewed
May 9, 2022
api/v1beta1/packetcluster_webhook.go
Outdated
Comment on lines
74
to
77
| if !reflect.DeepEqual(c.Spec.Facility, old.Spec.Facility) { | ||
| allErrs = append(allErrs, | ||
| field.Invalid(field.NewPath("spec", "VIPManager"), | ||
| c.Spec.Facility, "field is immutable"), |
There was a problem hiding this comment.
Looks like a copy/paste error. Shouldn't this all reference VIPManager and not Facility?
davidspek
reviewed
May 9, 2022
api/v1beta1/packetcluster_types.go
Outdated
|
|
||
| // VIPManager represents whether this cluster uses CPEM or kube-vip to | ||
| // manage its vip for the api server IP | ||
| VIPManager string `json:"vipManager"` |
There was a problem hiding this comment.
This should probably be an enum.
type VIPManagerType string
type PacketClusterSpec struct {
// VIPManager represents whether this cluster uses CPEM or kube-vip to
// manage its vip for the api server IP
// +kubebuilder:validation:Enum=CPEM;KUBE_VIP
VIPManager VIPManagerType `json:"vipManager"`
}It might also be good to add a default value by adding the following comment above the field.:
// +kubebuilder:default:=CPEMSigned-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
|
@cprivitere Awesome, looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to having the EIP_MANAGEMENT variable as part of the packetcluster Type
This is my attempt to implement what we discussed in Slack. I've moved the variable controlling whether we use kube-vip or CPEM into a field in the PacketCluster Type.