-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prod 2450/how to use plural docs #289
Conversation
✅ Deploy Preview for pluraldocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I added the docs for the placeholders are not added in the NavData |
``` | ||
|
||
|
||
### Create a New Repo for Plural |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't recommend they do this, instead let plural up
create the repo for them, which it does via oauth (and explain it can be cloned first if they can't do that due to permissioning constraints).
### Get Kubeconfig for the MGMT Cluster | ||
AWS | ||
```sh | ||
aws eks update-kubeconfig --name [CLUSTER_NAME] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plural wkspace kube-init
does that for you actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really cool!
I didn't know this feature existed
|
||
##### Add the RBAC Helm Values in the MGMT Cluster Repo | ||
```sh | ||
./helm-values/ConsoleClusterRoleBindings.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not put this in the helm-values
folder, that's git-crypted by default so should only be used for secret-ish things, create a new global service in a separate folder for rbac which contains this. Also don't camel-case filenames for k8s resources (not standard convention)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reference that Here: https://github.com/pluralsh/documentation/blob/main/pages/deployments/dashboard.md
should the doc just link to that or reiterate what the RBAC readme says?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaeljguarino I made the requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High level comments:
- honestly feel like the docs for setting up a management cluster should probably just link to our already thorough docs elsewhere
- there's a lot of incomplete content here I don't think we can merge and expose publicly
pages/how-to/set-up/mgmt-cluster.md
Outdated
|
||
##### Creating an RBAC Service | ||
* **Create an `rbac` dir in your MGMT repo | ||
and add the desired [k8s yaml](https://github.com/pluralsh/documentation/blob/main/pages/deployments/dashboard.md)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relative link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address
type: GITHUB | ||
``` | ||
### **Add an SCM Provider Webhook** | ||
If you navigate to `https://console.[YOUR DOMAIN].onplural.sh/pr/queue` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make these link urls: https://{your-console-domain}/pr/queue
(most serious users bring their own domain)
|
||
# Troubleshooting | ||
|
||
#### Get Kubeconfig for the MGMT Cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't make them troubleshoot w/ kubectl, they should be able to see this info in the CD ui (can also add the kubectl command as an addendum but should not be the primary flow as it's user-unfriendly)
|
||
|
||
|
||
# Troubleshooting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incomplete
![cluster-creator modal 2](/images/how-to/cluster-creator-modal-2.png) | ||
* **Merge the PR** | ||
* **Approve the Stack Run changes** | ||
* Navigate to `https://console.[YOUR DOMAIN].onplural.sh/staacks` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use console urls formatted as above
pages/how-to/upgrade/plural-cli.md
Outdated
@@ -0,0 +1,28 @@ | |||
--- | |||
title: Upgrading the Plural CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think we need these docs or at least not here if it's going to rabbithole users
pages/how-to/set-up/controllers.md
Outdated
* **Add a new `HelmRepository` CRD to your _infra_ repo `./apps/repositories`** | ||
* Example: `ingress-nginx.yaml` | ||
```yaml | ||
apiVersion: source.toolkit.fluxcd.io/v1beta2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use the native helm support not flux-based now that that's fully released. So this resource isn't necessary, and the repository
field in the helm block below can just be replaced withurl
pointing to the url in this CRD
src/NavData.tsx
Outdated
href: '/how-to/set-up/workload-cluster', | ||
}, | ||
{ | ||
title: 'SCM Connection', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll need to set up the scm connection before the workload cluster since it's a prereq. Also many users aren't going to understand the acronym, this should be titled something like Source Control Integration
or something like that.
# Prerequisites | ||
* **Plural Console `admin` Permissions** | ||
* **SCM Provider Personal Access Token** | ||
* [Github](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#creating-a-personal-access-token-classic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For github we should strongly nudge people to configure it via a github application which is technically more secure and not bound to a specific user.
* **Plural Console `admin` Permissions** | ||
* **SCM Provider Personal Access Token** | ||
* [Github](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#creating-a-personal-access-token-classic) | ||
* [GitLab](https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html#create-a-personal-access-token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use group or project tokens not personal tokens
* **SCM Provider Personal Access Token** | ||
* [Github](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#creating-a-personal-access-token-classic) | ||
* [GitLab](https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html#create-a-personal-access-token) | ||
* [Bitbucket](https://support.atlassian.com/bitbucket-cloud/docs/access-tokens/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, bitbucket has repo and org tokens that can be used
e874933
to
5aa334e
Compare
…s actually happening, corrects some mistakes and fixes the controller setup docs.
5aa334e
to
0733854
Compare
Summary
Add
How To
forplural up
, adding a workload cluster, scm connection, controllers and a few placeholdersLabels
enhancement
Test Plan
Viwed changes locally with
yarn dev
Checklist