Skip to content

Commit

Permalink
docs: Add External contributor flow docs (#631)
Browse files Browse the repository at this point in the history
* Add External contributor flow docs

will help us gate the publishing of non-plural developed apps in this repo.

* Remove limit on dagster job run

This was causing even trivial jobs to OOM and it will likely be replaced anyway by users, so bias to making sure it works for demos

* set primary recipes throughout
  • Loading branch information
michaeljguarino authored Apr 8, 2023
1 parent 2173ec1 commit 381a891
Show file tree
Hide file tree
Showing 17 changed files with 40 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/matrix-vendor-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ jobs:
uses: pluralsh/setup-plural@v0.1.5
with:
config: ${{ secrets.PLURAL_CONF }}
vsn: 0.6.17
vsn: 0.6.18
- run: plural apply -f ${{ matrix.pluralfile }}
- name: 'Run Semantic Release'
run: APP_NAME=${{ matrix.repository }} semantic-release
Expand Down
25 changes: 25 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,31 @@ plural deploy

This deploys the app with the local link you established. The `--force` flag will prevent any deduping w/in the Plural CLI from triggering.


### External Contributor Flow

For adding a new application the flow should be as follow:

* create an initial pr from the setup given by `plural create` above. You'll want to make sure the `repository.yaml` file is marked `private: true` and add your plural email to the list of contributors, eg:

```
name: airbyte
description: airbyte deployed on plural
category: DATA
release_status: ALPHA
private: true # keeps the repo from being publicly available to users until its ready
contributors:
- my@plural.email
...
```

You'll want to create a pr with that initial setup which will create the initial repository and mark yourself as a conributor.

* deploy a gcp or aws cluster to properly build and test the application, which can be done with the upgrade steps above
* publish a new pr with the final version, and if it's good to go, we can drop the privacy flag.
* if we're confident its ready for general use, we can move the `release_status` to `GA` or `BETA` as appropriate.


### Helpful utilities

If you're frequently updating Helm dependencies, it can be complicated to sync them locally. To make this easier, you can just run:
Expand Down
2 changes: 1 addition & 1 deletion baserow/plural/recipes/baserow-aws.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: baserow-aws
description: Installs baserow on an aws eks cluster
provider: AWS
primary: true
dependencies:
- repo: bootstrap
name: aws-k8s
- repo: ingress-nginx
name: ingress-nginx-aws

sections:
- name: baserow
configuration:
Expand Down
2 changes: 1 addition & 1 deletion baserow/plural/recipes/baserow-azure.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: baserow-azure
description: Installs baserow on an aws eks cluster
provider: AZURE
primary: true
dependencies:
- repo: bootstrap
name: azure-k8s
- repo: ingress-nginx
name: ingress-nginx-azure

sections:
- name: baserow
configuration:
Expand Down
2 changes: 1 addition & 1 deletion baserow/plural/recipes/baserow-gcp.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: baserow-gcp
description: Installs baserow on an aws eks cluster
provider: GCP
primary: true
dependencies:
- repo: bootstrap
name: gcp-k8s
- repo: ingress-nginx
name: ingress-nginx-gcp

sections:
- name: baserow
configuration:
Expand Down
1 change: 1 addition & 0 deletions dagster-agent/repository.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ description: dagster-agent deployed on plural
category: DATA
private: false
icon: plural/icons/dagster-primary-mark.png
darkIcon: plural/icons/dagster-primary-mark.png
notes: plural/notes.tpl
gitUrl: https://github.com/dagster-io/dagster
tags:
Expand Down
2 changes: 1 addition & 1 deletion dagster/helm/dagster/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: dagster
description: A Helm chart for Kubernetes
type: application
version: 0.1.30
version: 0.1.31
appVersion: 1.2.6
dependencies:
- name: postgres
Expand Down
2 changes: 0 additions & 2 deletions dagster/helm/dagster/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ dagster:
requests:
cpu: 20m
memory: 100Mi
limits:
memory: 160Mi
dagsterApiGrpcArgs:
- "--python-file"
- "/example_project/example_repo/repo.py"
Expand Down
2 changes: 1 addition & 1 deletion jenkins/plural/recipes/jenkins-aws.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: jenkins-aws
description: Installs jenkins on an aws eks cluster
provider: AWS
primary: true
dependencies:
- repo: bootstrap
name: aws-k8s
- repo: ingress-nginx
name: ingress-nginx-aws

sections:
- name: jenkins
configuration:
Expand Down
2 changes: 1 addition & 1 deletion jenkins/plural/recipes/jenkins-azure.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: jenkins-azure
description: Installs jenkins on an aws eks cluster
provider: AZURE
primary: true
dependencies:
- repo: bootstrap
name: azure-k8s
- repo: ingress-nginx
name: ingress-nginx-azure

sections:
- name: jenkins
configuration:
Expand Down
2 changes: 1 addition & 1 deletion jenkins/plural/recipes/jenkins-gcp.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: jenkins-gcp
description: Installs jenkins on an aws eks cluster
provider: GCP
primary: true
dependencies:
- repo: bootstrap
name: gcp-k8s
- repo: ingress-nginx
name: ingress-nginx-gcp

sections:
- name: jenkins
configuration:
Expand Down
2 changes: 1 addition & 1 deletion jupyterhub/plural/recipes/jupyterhub-aws.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: jupyterhub-aws
description: Installs jupyterhub on an aws eks cluster
provider: AWS
primary: true
dependencies:
- repo: bootstrap
name: aws-k8s
- repo: ingress-nginx
name: ingress-nginx-aws

sections:
- name: jupyterhub
configuration:
Expand Down
2 changes: 1 addition & 1 deletion jupyterhub/plural/recipes/jupyterhub-azure.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: jupyterhub-azure
description: Installs jupyterhub on an azure aks cluster
provider: AZURE
primary: true
dependencies:
- repo: bootstrap
name: azure-k8s
- repo: ingress-nginx
name: ingress-nginx-azure

sections:
- name: jupyterhub
configuration:
Expand Down
2 changes: 1 addition & 1 deletion jupyterhub/plural/recipes/jupyterhub-gcp.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: jupyterhub-gcp
description: Installs jupyterhub on an gcp gke cluster
provider: GCP
primary: true
dependencies:
- repo: bootstrap
name: gcp-k8s
- repo: ingress-nginx
name: ingress-nginx-gcp

sections:
- name: jupyterhub
configuration:
Expand Down
2 changes: 1 addition & 1 deletion tier/plural/recipes/tier-aws.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: tier-aws
description: Installs tier on an aws eks cluster
provider: AWS
primary: true
dependencies:
- repo: bootstrap
name: aws-k8s
- repo: ingress-nginx
name: ingress-nginx-aws

sections:
- name: tier
configuration:
Expand Down
2 changes: 1 addition & 1 deletion tier/plural/recipes/tier-azure.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: tier-azure
description: Installs tier on an azure aks cluster
provider: AZURE
primary: true
dependencies:
- repo: bootstrap
name: azure-k8s
- repo: ingress-nginx
name: ingress-nginx-azure

sections:
- name: tier
configuration:
Expand Down
2 changes: 1 addition & 1 deletion tier/plural/recipes/tier-gcp.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: tier-gcp
description: Installs tier on an gcp gke cluster
provider: GCP
primary: true
dependencies:
- repo: bootstrap
name: gcp-k8s
- repo: ingress-nginx
name: ingress-nginx-gcp

sections:
- name: tier
configuration:
Expand Down

0 comments on commit 381a891

Please sign in to comment.