Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sysbox): onboard sysbox as a secure container runtime #788

Merged
merged 90 commits into from
Aug 16, 2023
Merged

Conversation

rauerhans
Copy link
Collaborator

@rauerhans rauerhans commented Jul 27, 2023

Summary

This artifact adds the sysbox nodegroup to the cluster it's installed into and adds the sysbox runtimeClass. The custom AMI is built here https://github.com/pluralsh/sysbox-eks-ami

Test Plan

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

sysbox/Pluralfile Outdated Show resolved Hide resolved
@rauerhans rauerhans marked this pull request as ready for review August 16, 2023 13:10
@rauerhans rauerhans changed the title Feat/sysbox Feat: sysbox Aug 16, 2023
@rauerhans rauerhans changed the title Feat: sysbox feat: sysbox Aug 16, 2023
Copy link
Contributor

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidspek davidspek changed the title feat: sysbox feat(sysbox): onboard sysbox as a secure container runtime Aug 16, 2023
@rauerhans rauerhans merged commit 39c2aaa into main Aug 16, 2023
7 of 18 checks passed
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants