Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interrupt full screen apps #11

Open
TravisBumgarner opened this issue Oct 31, 2018 · 4 comments
Open

Interrupt full screen apps #11

TravisBumgarner opened this issue Oct 31, 2018 · 4 comments

Comments

@TravisBumgarner
Copy link
Contributor

When mobbing with Visual Code set to full screen the mob timer won't interrupt the app when time's up. It'd be nice if this was possible.

@allan-stewart
Copy link
Contributor

I'm guessing that you are talking about Mac OS's full screen ability? If so, I poked around a bit and found this electron issue that discusses what I think we'd need: electron/electron#10078

Based on my read of that thread, we might be able to do the full screen interrupt if we play around with some of the existing options. But we might need a feature that does not yet exist, and it looks like there has been no activity on that PR in a while...

I'm not sure when I'd get the time to mess with this, but hopefully somebody will take a crack at it. (I also don't use full screen very often on Mac, so I'm not sure I'm the right audience.) Also related: I wonder how the timer does with spaces (multiple virtual windows)?

@TravisBumgarner
Copy link
Contributor Author

TravisBumgarner commented Nov 2, 2018

Womp womp. I'd be down to perhaps explore this in the future. Don't know anything about Electron though. Maybe now's a good time to start.

@dignite
Copy link
Contributor

dignite commented Nov 3, 2018

@TravisBumgarner please try out #17 and feedback, my initial tests worked well but always good to get some new perspectives and tests on more devices

@allan-stewart
Copy link
Contributor

I've merged #17 -- if that works sufficiently, we can close this issue. Unfortunately we do have to fight against Electron / MacOS limitations (and how they differ from the core concept of the timer) as discussed in the PR. But I'm hopeful that it's usable for full-screen users as-is now.

dignite pushed a commit to dignite/mob-timer that referenced this issue Jun 3, 2019
* Remove mention of old integration tests

* Rename an mention fork source

* Remove motivation, add contributing section

* Link to releases

* Add reasons for forking

* Refer to "mob-timer" consistently

* Add licence shield

* Add contributors shield

* Add master build shield

* Add download count shield

* Add Github open "idea" issues shield

* Add github release version shield
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants