Skip to content

Commit

Permalink
deps: V8: cherry-pick 9f4b7699f68e
Browse files Browse the repository at this point in the history
Original commit message:

    Fix mistake in the skip branch of test/mjsunit/regress-1320641.js

    It was doing a `string.test(regex)` which was wrong. It's supposed
    to be `regex.test(string)`. It wasn't caught in the CI because
    the skip path is not normally taken in the V8 CI.

    Change-Id: Id1bdab5bbc41968bba8adc1cb3664e8f95fb5d72
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4697855
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#89044}

Refs: v8/v8@9f4b769
PR-URL: nodejs#48830
Refs: v8/v8@c1a54d5
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
  • Loading branch information
joyeecheung authored and pluris committed Aug 7, 2023
1 parent d4b47b7 commit fac8a0e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.12',
'v8_embedder_string': '-node.13',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/test/mjsunit/regress/regress-1320641.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var skip = false;
try {
new Uint16Array(3775336418);
} catch (e) {
if (e.message.test(/Array buffer allocation failed/)) {
if (/Array buffer allocation failed/.test(e.message)) {
skip = true; // We don't have enough memory, just skip the test.
}
}
Expand Down

0 comments on commit fac8a0e

Please sign in to comment.