Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(base): update resource ID generation to handle Unicode characters #313

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jianzs
Copy link
Contributor

@jianzs jianzs commented Aug 5, 2024

The resource ID generation logic has been updated in both Python and TypeScript files to handle Unicode characters. This ensures that Unicode characters are properly encoded in the resource ID string, preventing any issues with special characters. The encode_unicode function has been added to both files to handle the encoding. This improvement enhances the reliability and compatibility of the resource ID generation process.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • Base SDK

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

The resource ID generation logic has been updated in both Python and TypeScript files to handle Unicode characters. This ensures that Unicode characters are properly encoded in the resource ID string, preventing any issues with special characters. The `encode_unicode` function has been added to both files to handle the encoding. This improvement enhances the reliability and compatibility of the resource ID generation process.
@jianzs jianzs added the sdk Client SDK and Infra SDK label Aug 5, 2024
Copy link

changeset-bot bot commented Aug 5, 2024

🦋 Changeset detected

Latest commit: 2b2e2d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@plutolang/base Patch
@plutolang/cli Patch
@plutolang/pulumi-adapter Patch
@plutolang/simulator-adapter Patch
@plutolang/pyright-deducer Patch
@plutolang/static-deducer Patch
@plutolang/graphviz-generator Patch
@plutolang/static-generator Patch
@plutolang/pluto-infra Patch
@plutolang/pluto Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jianzs jianzs merged commit dbbfde4 into pluto-lang:main Aug 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk Client SDK and Infra SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant