feat(crdt-yjs): 1s merge interval (#859)

pluv-io · Jan 21, 2025 · 820898c · 820898c
1 parent 4612279
commit 820898c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/.changeset/proud-apricots-serve.md b/.changeset/proud-apricots-serve.md
@@ -0,0 +1,5 @@
+---
+"@pluv/crdt-yjs": patch
+---
+
+Increase undo/redo merge interval from 0s to 1s.
diff --git a/packages/crdt-loro/src/doc/CrdtLoroDoc.ts b/packages/crdt-loro/src/doc/CrdtLoroDoc.ts
@@ -5,6 +5,9 @@ import type { Container } from "loro-crdt";
 import { LoroDoc, LoroEventBatch, LoroList, LoroMap, LoroText, UndoManager, isContainer } from "loro-crdt";
 import type { LoroType } from "../types";
 
+const MAX_UNDO_STEPS = 100;
+const MERGE_INTERVAL_MS = 1_000;
+
 export class CrdtLoroDoc<TStorage extends Record<string, LoroType<any, any>>> extends AbstractCrdtDoc<TStorage> {
     public value: LoroDoc = new LoroDoc();
 
@@ -190,8 +193,8 @@ export class CrdtLoroDoc<TStorage extends Record<string, LoroType<any, any>>> ex
         }
 
         this._undoManager = new UndoManager(this.value, {
-            maxUndoSteps: 100,
-            mergeInterval: 1_000, // 1_000ms,
+            maxUndoSteps: MAX_UNDO_STEPS,
+            mergeInterval: MERGE_INTERVAL_MS,
         });
 
         return this;

diff --git a/packages/crdt-yjs/src/doc/CrdtYjsDoc.ts b/packages/crdt-yjs/src/doc/CrdtYjsDoc.ts
@@ -22,6 +22,8 @@ import type { YjsType } from "../types";
 import { YjsXmlElement } from "../xmlElement/YjsXmlElement";
 import { YjsXmlText } from "../xmlText/YjsXmlText";
 
+const MERGE_INTERVAL_MS = 1_000;
+
 export class CrdtYjsDoc<TStorage extends Record<string, YjsType<any, any>>> extends AbstractCrdtDoc<TStorage> {
     public value: YDoc = new YDoc();
 
@@ -205,7 +207,7 @@ export class CrdtYjsDoc<TStorage extends Record<string, YjsType<any, any>>> exte
             return this;
         }
 
-        this._undoManager = new UndoManager(sharedTypes, { captureTimeout: 0 });
+        this._undoManager = new UndoManager(sharedTypes, { captureTimeout: MERGE_INTERVAL_MS });
 
         return this;
     }