Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed vscode URL #1058

Closed
cincauhangus opened this issue Oct 1, 2024 · 3 comments
Closed

Malformed vscode URL #1058

cincauhangus opened this issue Oct 1, 2024 · 3 comments

Comments

@cincauhangus
Copy link

cincauhangus commented Oct 1, 2024

Hello, I encountered some issues trying to launch IDE from the main page. Note: I am running on Windows.

Incorrect:

<td class="path"><a href="vscode://file{{../basePath}}/routes{{route.path}}.ts">{{route.path}}</a></td>

vscode://file (missing trailing slash)

Correct:

<a slot="get-{{escape_route route}}" href="vscode://file/{{../basePath}}/routes/{{.}}.ts">Edit in VSCode</a>

vscode://file/ (trailing slash)

@pmcelhaney
Copy link
Owner

Good catch. How did you even find this? Rapidoc at this point is undocumented and broken. I should remove that code altogether.

(If you'd rather me keep Rapidoc in and fix it, let me know. :))

@cincauhangus
Copy link
Author

I found it when i tried to click on the path names on the counterfact page - http://localhost:3100/counterfact/

@pmcelhaney
Copy link
Owner

Oh, I mixed up the correct and incorrect. I'll fix it. Thanks!

pmcelhaney added a commit that referenced this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants