-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support perfect forwarding of arguments #116
Comments
I think Line 25 in 688e9e1
|
There is a problem with the return detail::call_from_v8<Traits>(&factory<T, Traits>::template create<Args&&...>, args); would fail on such a specialized factory (see https://github.com/pmed/v8pp/blob/master/test/test_class.cpp#L95 for example). I currently have no idea how to deal with this. Newer |
OK I see... Thanks anyway for your hard work! ;-) Maybe there is a solution for this, but currently I also have no clue... |
If you define custom factories which take their arguments by reference instead by value, v8pp::class_::create_object() doesn't play well.
As a workaround you have to create the object manually:
So it would be nice if v8pp would support Perfect Forwarding.
This would also eliminate the use of custom factories for reference arguments?
Thanks!
The text was updated successfully, but these errors were encountered: