Fix test that fails when v8 is built with is_debug and dcheck_always_on #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmed
reviewed
Nov 1, 2021
|
Hi Alex, Thanks a lot! |
|
Hi Alex, I've fixed macOS build on GitHub Actions (issue #176) |
…on, due to isolate related issues.
|
Rebased and squashed. |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of v8 DCHECK assertions related to the isolate not being set in the test when v8::ScriptOrigin needed it, and the Isolate not being cleaned up before shutting down v8. Tested with v8 9.4.146.22.