test: ex_libpmem2/TEST6 should not be run under pmemcheck #5618
Conversation
Codecov Report
@@ Coverage Diff @@
## stable-1.13 #5618 +/- ##
===============================================
- Coverage 74.26% 74.25% -0.01%
===============================================
Files 145 145
Lines 22131 22131
Branches 3704 3704
===============================================
- Hits 16435 16433 -2
- Misses 5696 5698 +2 |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ldorau)
src/test/ex_libpmem2/TESTS.py line 86 at r1 (raw file):
@t.windows_exclude @t.require_valgrind_disabled('pmemcheck')
Please add the comment from the commit message here. It will be easier to follow exclusions this way.
ex_libpmem2/TEST6 would require two VALGRIND_SET_CLEAN() calls to be added to the "src/examples/libpmem2/ringbuf/ringbuf.c" example (see pmem#5604) in order to pass under pmemcheck, but it seems that examples do not use valgrind macros on purpose (to avoid unnecessary complication), so this test just should not be run under pmemcheck. Fixes: pmem#5598 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
test-ex_libpmem2-TEST6-should-not-be-run-under-pmemcheck
branch
from
b4979f1 to
f6feb07
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @janekmi)
src/test/ex_libpmem2/TESTS.py line 86 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
Please add the comment from the commit message here. It will be easier to follow exclusions this way.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ldorau)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
ldorau
deleted the
test-ex_libpmem2-TEST6-should-not-be-run-under-pmemcheck
branch
ex_libpmem2/TEST6would require twoVALGRIND_SET_CLEAN()calls to be added to the "src/examples/libpmem2/ringbuf/ringbuf.c" example (see #5604) in order to pass under pmemcheck, but it seems that examples do not use valgrind macros on purpose (to avoid unnecessary complication), so this test just should not be run under pmemcheck.Fixes: #5598
This change is