-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: disable ex_libpmem2/TEST5 with memcheck #5667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @grom72)
src/test/ex_libpmem2/TESTS.py
line 101 at r1 (raw file):
# additionall test TEST501 has been added to cover non-pmemcheck configs. @t.require_valgrind_disabled('memcheck', ) # to be removed when fixed @t.require_valgrind_disabled('pmemcheck')
It shouldn't be: @t.require_valgrind_disabled('memcheck', 'pmemcheck')?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72 and @t)
src/test/ex_libpmem2/TESTS.py
line 78 at r1 (raw file):
# XXX Disable the test execution under pmemcheck with g.PAGE and # g.CACHELINE until the issue
CACHELINE is required for TEST5. I think the previous condition in the comment was correct.
src/test/ex_libpmem2/TESTS.py
line 101 at r1 (raw file):
Previously, osalyk (Oksana Sałyk) wrote…
It shouldn't be: @t.require_valgrind_disabled('memcheck', 'pmemcheck')?
👍
In case somebody will find it useful:
Granularity\Valgrind | none | memcheck | pmemcheck | drd/helgrind |
---|---|---|---|---|
page | TEST501 | TEST501 -> disabled | disabled | TEST501 |
cache | TEST501 | TEST501 -> disabled | TEST5 | TEST501 |
byte | TEST501 | TEST501 -> disabled | TEST5 | TEST501 |
It was too hard for me to validate it in my head. I had to draw a table.
Disable ex_libpmem2/TEST5 with memcheck until issue pmem#5635 is fixed. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @janekmi and @t)
src/test/ex_libpmem2/TESTS.py
line 78 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
CACHELINE is required for TEST5. I think the previous condition in the comment was correct.
Done.
src/test/ex_libpmem2/TESTS.py
line 101 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
👍
In case somebody will find it useful:
Granularity\Valgrind none memcheck pmemcheck drd/helgrind page TEST501 TEST501 -> disabled disabled TEST501 cache TEST501 TEST501 -> disabled TEST5 TEST501 byte TEST501 TEST501 -> disabled TEST5 TEST501 It was too hard for me to validate it in my head. I had to draw a table.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @janekmi and @t)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi and @t)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
Codecov Report
@@ Coverage Diff @@
## stable-1.13 #5667 +/- ##
============================================
Coverage 74.27% 74.28%
============================================
Files 145 145
Lines 22131 22131
Branches 3704 3705 +1
============================================
+ Hits 16437 16439 +2
+ Misses 5694 5692 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
Disable ex_libpmem2/TEST5 with memcheck until issue #5635 is fixed.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)