Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

err() with explicit errno #5976

Merged
merged 1 commit into from
Jan 29, 2024
Merged

err() with explicit errno #5976

merged 1 commit into from
Jan 29, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Jan 25, 2024

Requires:


This change is Reviewable

@grom72 grom72 added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Jan 25, 2024
@grom72 grom72 requested a review from janekmi January 25, 2024 11:05
@grom72 grom72 force-pushed the ERR-w-explicit-errno branch 3 times, most recently from cf625a5 to 43fd1cf Compare January 26, 2024 09:21
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e3debc6) 68.49% compared to head (3ae2638) 68.50%.
Report is 2 commits behind head on master.

❗ Current head 3ae2638 differs from pull request most recent head 6a9fea9. Consider uploading reports for the commit 6a9fea9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5976   +/-   ##
=======================================
  Coverage   68.49%   68.50%           
=======================================
  Files         133      133           
  Lines       19658    19650    -8     
  Branches     3260     3260           
=======================================
- Hits        13465    13461    -4     
+ Misses       6193     6189    -4     

@grom72 grom72 force-pushed the ERR-w-explicit-errno branch from 43fd1cf to 3ae2638 Compare January 29, 2024 10:01
@grom72 grom72 mentioned this pull request Jan 29, 2024
1 task
Remove "!..." logic from error message format string.
Use separate argument to either use or not use errno in error message.
Remove non-posix version of util_strerror.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 54 of 56 files at r1, 7 of 8 files at r2, 1 of 1 files at r3, 24 of 24 files at r4, 1 of 2 files at r5, 6 of 6 files at r6, 2 of 2 files at r7, 2 of 2 files at r8, 7 of 7 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@grom72 grom72 force-pushed the ERR-w-explicit-errno branch from 3ae2638 to 6a9fea9 Compare January 29, 2024 17:02
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 96 of 96 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@janekmi janekmi merged commit 87d34cf into pmem:master Jan 29, 2024
5 checks passed
@grom72 grom72 deleted the ERR-w-explicit-errno branch February 15, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants