-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
err() with explicit errno #5976
Conversation
cf625a5
to
43fd1cf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5976 +/- ##
=======================================
Coverage 68.49% 68.50%
=======================================
Files 133 133
Lines 19658 19650 -8
Branches 3260 3260
=======================================
- Hits 13465 13461 -4
+ Misses 6193 6189 -4 |
43fd1cf
to
3ae2638
Compare
Remove "!..." logic from error message format string. Use separate argument to either use or not use errno in error message. Remove non-posix version of util_strerror. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 54 of 56 files at r1, 7 of 8 files at r2, 1 of 1 files at r3, 24 of 24 files at r4, 1 of 2 files at r5, 6 of 6 files at r6, 2 of 2 files at r7, 2 of 2 files at r8, 7 of 7 files at r9, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
3ae2638
to
6a9fea9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 96 of 96 files at r10, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
Requires:
This change is