Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pmem: disable flag verification until #5979 is fixed #5980

Merged
merged 1 commit into from
Jan 25, 2024
Merged

pmem: disable flag verification until #5979 is fixed #5980

merged 1 commit into from
Jan 25, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Jan 25, 2024 •
edited
Loading

This change is Reviewable

@grom72 grom72 requested a review from janekmi January 25, 2024 12:54
@janekmi janekmi added no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint labels Jan 25, 2024
janekmi
janekmi approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@grom72
pmem: disable flag verification until pmem#5979 is fixed
ac4f3c9 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 force-pushed the disable-5979 branch 2 times, most recently from fb82005 to ac4f3c9 Compare January 25, 2024 13:08
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2db02a) 68.47% compared to head (fb82005) 68.47%.
Report is 6 commits behind head on master.

❗ Current head fb82005 differs from pull request most recent head ac4f3c9. Consider uploading reports for the commit ac4f3c9 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5980      +/-   ##
==========================================
- Coverage   68.47%   68.47%   -0.01%     
==========================================
  Files         133      133              
  Lines       19660    19658       -2     
  Branches     3261     3260       -1     
==========================================
- Hits        13463    13460       -3     
- Misses       6197     6198       +1

@janekmi janekmi merged commit 069c860 into pmem:master Jan 25, 2024
4 of 6 checks passed
@grom72 grom72 deleted the disable-5979 branch January 25, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janekmi janekmi janekmi approved these changes

Assignees
No one assigned
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grom72 @janekmi