Improve docker images #124
Conversation
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)
utils/docker/images/Dockerfile.ubuntu-20.04, line 75 at r1 (raw file):
# Setup maven settings COPY setup-maven-settings.sh setup-maven-settings.sh RUN ./setup-maven-settings.sh
Proxy configuration should be rather set at image startup (entrypoint).
lukaszstolarczuk
force-pushed
the
improve-docker-images
branch
2 times, most recently
from
341c6ec to
e93cadd
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @karczex and @KFilipek)
utils/docker/images/Dockerfile.ubuntu-20.04, line 75 at r1 (raw file):
Previously, karczex (Paweł Karczewski) wrote…
Proxy configuration should be rather set at image startup (entrypoint).
Done.
These settings are based on http_proxy/https_proxy variables given as docker build_arg(s). A build_arg's format should be e.g., as follows: --build-arg http[s]_proxy=http://<server>.<domain>:<port_addr> setup-maven-settings.sh is also set to run within user's .bashrc, for containers runtime setup.
lukaszstolarczuk
force-pushed
the
improve-docker-images
branch
from
e93cadd to
511b6a9
Compare
There was a problem hiding this comment.
Reviewed 1 of 6 files at r2.
Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @karczex and @KFilipek)
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)
note: If you got better idea/approach for the last commit, please let me know.
I believe, though, proxy settings are enough for now, we rather don't use more than that, aren't we?
This change is