common: move on to the new coverage uploader #2126

ldorau · 2023-03-14T10:42:04Z

Move on to the new coverage uploader.
The old bash uploader is long EOL now.

This change is

ldorau

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion

a discussion (no related file):
Something is not working yet (unusable report): https://app.codecov.io/github/pmem/rpma/commit/3e89b0b4957d9831ced07684f04a2191b7f6a241

lukaszstolarczuk

Reviewable status: 0 of 5 files reviewed, 4 unresolved discussions (waiting on @ldorau)

.github/workflows/coverage.yml line 30 at r1 (raw file):

    steps:
       - name: Clone the git repo
         uses: actions/checkout@v1

I believe there's v3 already

.github/workflows/coverage.yml line 40 at r1 (raw file):

       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v3
         with:

you can enable verbose log: verbose: true

utils/docker/build.sh line 74 at r1 (raw file):

docker run --privileged=true --name=$containerName -i $TTY \
	$DNS_SETTING \
	${docker_opts} \

redundant now, I believe

grom72

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @ldorau and @lukaszstolarczuk)

ldorau

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @grom72 and @lukaszstolarczuk)

.github/workflows/coverage.yml line 30 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

I believe there's v3 already

Done.

Code quote:

uses: actions/checkout@v1

.github/workflows/coverage.yml line 40 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

you can enable verbose log: verbose: true

Done

utils/docker/build.sh line 74 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

redundant now, I believe

Right.

Code quote:

${docker_opts}

grom72

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @lukaszstolarczuk)

yangx-jy

Reviewable status: 4 of 5 files reviewed, 7 unresolved discussions (waiting on @grom72, @ldorau, and @lukaszstolarczuk)

.github/workflows/coverage.yml line 33 at r3 (raw file):

       - name: Pull or rebuild the image
         run: cd $WORKDIR && ${{ matrix.CONFIG }} ./pull-or-rebuild-image.sh

You may need to use the following definition for ${{ matrix.CONFIG }}:

      matrix:
        CONFIG: ["N=1 OS=ubuntu OS_VER=latest TYPE=normal CC=gcc" TESTS_COVERAGE=1]

or remove ${{ matrix.CONFIG }} directly.

.github/workflows/coverage.yml line 36 at r3 (raw file):

       - name: Run the build
         run: cd $WORKDIR && ${{ matrix.CONFIG }} ./build.sh

The same comment.

.github/workflows/coverage.yml line 39 at r3 (raw file):

       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v3

Is download-scripts.sh still necessary if we plan to use download-scripts.sh?

yangx-jy · 2023-03-16T05:09:36Z

.github/workflows/coverage.yml line 39 at r3 (raw file):

Previously, yangx-jy (Xiao Yang) wrote…

Is download-scripts.sh still necessary if we plan to use download-scripts.sh?

Sorry, I mean that we plan to use codecov/codecov-action@v3.

Code quote:

codecov/codecov-action@v3

ldorau

Reviewable status: 4 of 5 files reviewed, 7 unresolved discussions (waiting on @grom72, @lukaszstolarczuk, and @yangx-jy)

.github/workflows/coverage.yml line 33 at r3 (raw file):

Previously, yangx-jy (Xiao Yang) wrote…

You may need to use the following definition for ${{ matrix.CONFIG }}:
      matrix:
        CONFIG: ["N=1 OS=ubuntu OS_VER=latest TYPE=normal CC=gcc" TESTS_COVERAGE=1]
or remove ${{ matrix.CONFIG }} directly.

It's just a missed leftover. I removed the build matrix on purpose and just forgot to remove it.

Removed.

.github/workflows/coverage.yml line 36 at r3 (raw file):

Previously, yangx-jy (Xiao Yang) wrote…

The same comment.

Done.

.github/workflows/coverage.yml line 39 at r3 (raw file):

Previously, yangx-jy (Xiao Yang) wrote…

Sorry, I mean that we plan to use codecov/codecov-action@v3.

Right, they will not be needed. Removed.

lukaszstolarczuk

Reviewed 2 of 5 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @grom72 and @yangx-jy)

yangx-jy

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

ldorau

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

a discussion (no related file):

Previously, ldorau (Lukasz Dorau) wrote…

Something is not working yet: https://app.codecov.io/github/pmem/rpma/commit/3e89b0b4957d9831ced07684f04a2191b7f6a241

The last result (still "unusable report"): https://app.codecov.io/github/pmem/rpma/commit/ac0240e7d421d64310f4d0106f30432e886c5e59

lukaszstolarczuk · 2023-03-17T08:48:08Z

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

a discussion (no related file):

Previously, ldorau (Lukasz Dorau) wrote…
The last result (still "unusable report"): https://app.codecov.io/github/pmem/rpma/commit/ac0240e7d421d64310f4d0106f30432e886c5e59

if you believe you checked everything and are convinced you're doing everything right - you can ask Codecov team for help. They were usually very helpful on their forum.

ldorau

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @lukaszstolarczuk)

a discussion (no related file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

if you believe you checked everything and are convinced you're doing everything right - you can ask Codecov team for help. They were usually very helpful on their forum.

Let's see: https://community.codecov.com/t/unusable-report-using-codecov-action-v3-bash-uploader-works-well/4223

grom72

Reviewed 1 of 1 files at r3, 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

grom72

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

ldorau

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

a discussion (no related file):

Previously, ldorau (Lukasz Dorau) wrote…

Let's see: https://community.codecov.com/t/unusable-report-using-codecov-action-v3-bash-uploader-works-well/4223

Waiting for help from the support team: https://community.codecov.com/t/unusable-report-using-codecov-action-v3-bash-uploader-works-well/4223 ...

Move on to the new coverage uploader. The old bash uploader is long EOL now. See: pmem/pmdk#5548

grom72

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

grom72

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ldorau and @lukaszstolarczuk)

a discussion (no related file):

Previously, ldorau (Lukasz Dorau) wrote…

Waiting for help from the support team: https://community.codecov.com/t/unusable-report-using-codecov-action-v3-bash-uploader-works-well/4223 ...

@ldorau, does it work now as expected?

ldorau

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @lukaszstolarczuk)

a discussion (no related file):

Previously, grom72 (Tomasz Gromadzki) wrote…

@ldorau, does it work now as expected?

No, it still does not work

yangx-jy · 2023-05-08T05:50:36Z

Previously, ldorau (Lukasz Dorau) wrote…

No, it still does not work

Is there any progress on this PR? ^_^

ldorau

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

a discussion (no related file):

Previously, yangx-jy (Xiao Yang) wrote…

Is there any progress on this PR? ^_^

The codecov/codecov-action@v3 action still does not work as expected:
https://community.codecov.com/t/unusable-report-using-codecov-action-v3-bash-uploader-works-well/4223/17

yangx-jy · 2023-05-16T13:47:26Z

Previously, ldorau (Lukasz Dorau) wrote…

The codecov/codecov-action@v3 action still does not work as expected:
https://community.codecov.com/t/unusable-report-using-codecov-action-v3-bash-uploader-works-well/4223/17

It seems hard to make a progress on the issue. Do we have any other ideas? When do you prepare to do the release?

ldorau

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

a discussion (no related file):

Previously, yangx-jy (Xiao Yang) wrote…

It seems hard to make a progress on the issue. Do we have any other ideas? When do you prepare to do the release?

v1.3.0 released: https://github.com/pmem/rpma/releases/tag/1.3.0

yangx-jy · 2023-05-25T13:44:22Z

Previously, ldorau (Lukasz Dorau) wrote…

v1.3.0 released: https://github.com/pmem/rpma/releases/tag/1.3.0

@ldorau Great. Thanks a lot for your help.

ldorau

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72, @lukaszstolarczuk, and @yangx-jy)

a discussion (no related file):

Previously, yangx-jy (Xiao Yang) wrote…

@ldorau Great. Thanks a lot for your help.

You are welcome :-)

ldorau force-pushed the common-move-on-to-the-new-coverage-uploader branch from 619389a to 3e89b0b Compare March 14, 2023 12:02

ldorau marked this pull request as draft March 14, 2023 12:02

ldorau commented Mar 14, 2023

View reviewed changes

lukaszstolarczuk reviewed Mar 15, 2023

View reviewed changes

grom72 approved these changes Mar 15, 2023

View reviewed changes

ldorau requested a review from grom72 March 15, 2023 14:49

ldorau commented Mar 15, 2023

View reviewed changes

ldorau force-pushed the common-move-on-to-the-new-coverage-uploader branch from 3e89b0b to 894cc09 Compare March 15, 2023 14:49

grom72 approved these changes Mar 15, 2023

View reviewed changes

ldorau force-pushed the common-move-on-to-the-new-coverage-uploader branch from 894cc09 to d132e58 Compare March 15, 2023 18:34

yangx-jy reviewed Mar 16, 2023

View reviewed changes

ldorau force-pushed the common-move-on-to-the-new-coverage-uploader branch from d132e58 to ac0240e Compare March 16, 2023 07:58

ldorau requested a review from grom72 March 16, 2023 07:58

ldorau commented Mar 16, 2023

View reviewed changes

lukaszstolarczuk reviewed Mar 16, 2023

View reviewed changes

yangx-jy reviewed Mar 17, 2023

View reviewed changes

ldorau commented Mar 17, 2023

View reviewed changes

ldorau commented Mar 23, 2023

View reviewed changes

grom72 approved these changes Mar 23, 2023

View reviewed changes

ldorau commented Mar 28, 2023

View reviewed changes

common: move ASAN and UBSAN build after code coverage check

8a6a427

ldorau force-pushed the common-move-on-to-the-new-coverage-uploader branch from ac0240e to 333b79b Compare April 14, 2023 13:33

common: move on to the new coverage uploader

2660e6b

Move on to the new coverage uploader. The old bash uploader is long EOL now. See: pmem/pmdk#5548

ldorau force-pushed the common-move-on-to-the-new-coverage-uploader branch from 333b79b to 2660e6b Compare April 14, 2023 13:47

grom72 reviewed Apr 17, 2023

View reviewed changes

ldorau requested a review from grom72 April 17, 2023 07:37

ldorau commented Apr 17, 2023

View reviewed changes

ldorau commented May 8, 2023

View reviewed changes

ldorau commented May 25, 2023

View reviewed changes

ldorau commented May 31, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

common: move on to the new coverage uploader #2126

common: move on to the new coverage uploader #2126

ldorau commented Mar 14, 2023 •

edited

Loading

ldorau left a comment •

edited

Loading

lukaszstolarczuk left a comment

grom72 left a comment

ldorau left a comment

grom72 left a comment

yangx-jy left a comment

yangx-jy commented Mar 16, 2023

ldorau left a comment

lukaszstolarczuk left a comment

yangx-jy left a comment

ldorau left a comment

lukaszstolarczuk commented Mar 17, 2023

ldorau left a comment

grom72 left a comment

grom72 left a comment

ldorau left a comment

grom72 left a comment

grom72 left a comment

ldorau left a comment

yangx-jy commented May 8, 2023

ldorau left a comment

yangx-jy commented May 16, 2023

ldorau left a comment

yangx-jy commented May 25, 2023

ldorau left a comment

common: move on to the new coverage uploader #2126

Are you sure you want to change the base?

common: move on to the new coverage uploader #2126

Conversation

ldorau commented Mar 14, 2023 • edited Loading

ldorau left a comment • edited Loading

Choose a reason for hiding this comment

lukaszstolarczuk left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

ldorau left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

yangx-jy left a comment

Choose a reason for hiding this comment

yangx-jy commented Mar 16, 2023

ldorau left a comment

Choose a reason for hiding this comment

lukaszstolarczuk left a comment

Choose a reason for hiding this comment

yangx-jy left a comment

Choose a reason for hiding this comment

ldorau left a comment

Choose a reason for hiding this comment

lukaszstolarczuk commented Mar 17, 2023

ldorau left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

ldorau left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

ldorau left a comment

Choose a reason for hiding this comment

yangx-jy commented May 8, 2023

ldorau left a comment

Choose a reason for hiding this comment

yangx-jy commented May 16, 2023

ldorau left a comment

Choose a reason for hiding this comment

yangx-jy commented May 25, 2023

ldorau left a comment

Choose a reason for hiding this comment

ldorau commented Mar 14, 2023 •

edited

Loading

ldorau left a comment •

edited

Loading