-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.4.0 support #142
base: fork
Are you sure you want to change the base?
PHP 8.4.0 support #142
Conversation
Please provide sources of information for your changes. |
Please add 8.4 here ext-pmmpthread/.github/workflows/main.yml Line 14 in a6f7d22
and here Line 8 in a6f7d22
|
Main branch now supports Windows CI via GitHub Actions (which also has much more comprehensive testing). I'd like to see it run this PR before merging. Please merge the branches and add 8.4 to the Windows CI as well. |
Looks like https://github.com/php/php-src/releases/tag/php-8.4.0RC4 would be better suited for testing |
|
I've fixed the 8.4 Windows build. Some of the tests need adapting to PHP 8.4. Some of the outputs from 8.4 are different. Closures var_dump() more info, some error messages are different, and some object IDs in outputs changed. Other tests are showing debug asserts that need to be fixed. |
rebuild_object_properties
has been changed tozend_std_get_properties_ex
php/php-src@1fbb666
user.doc_comment
has been removed.php/php-src@f2e199e#diff-49d1aeab0b09a6f9d475cd503187847f2d930989bfe729496a949e574d067649L227%60