Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4.0 support #142

Open
wants to merge 22 commits into
base: fork
Choose a base branch
from
Open

PHP 8.4.0 support #142

wants to merge 22 commits into from

Conversation

AkmalFairuz
Copy link

@AkmalFairuz AkmalFairuz commented Nov 17, 2024

src/handlers.c Outdated Show resolved Hide resolved
src/prepare.c Outdated Show resolved Hide resolved
src/store.c Outdated Show resolved Hide resolved
@dktapps
Copy link
Member

dktapps commented Nov 17, 2024

Please provide sources of information for your changes.

src/prepare.c Show resolved Hide resolved
@dktapps
Copy link
Member

dktapps commented Nov 17, 2024

Please add 8.4 here


and here

appveyor.yml Outdated Show resolved Hide resolved
@dktapps
Copy link
Member

dktapps commented Nov 18, 2024

Main branch now supports Windows CI via GitHub Actions (which also has much more comprehensive testing). I'd like to see it run this PR before merging. Please merge the branches and add 8.4 to the Windows CI as well.

@dktapps
Copy link
Member

dktapps commented Nov 18, 2024

Looks like https://github.com/php/php-src/releases/tag/php-8.4.0RC4 would be better suited for testing

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@dktapps
Copy link
Member

dktapps commented Nov 18, 2024

PHP_SDK_BINARY_TOOLS_VER: 2.2.0
need to bump this to 2.3.0

@dktapps dktapps closed this Nov 18, 2024
@dktapps dktapps reopened this Nov 18, 2024
@dktapps
Copy link
Member

dktapps commented Nov 18, 2024

I've fixed the 8.4 Windows build.

Some of the tests need adapting to PHP 8.4. Some of the outputs from 8.4 are different. Closures var_dump() more info, some error messages are different, and some object IDs in outputs changed.

Other tests are showing debug asserts that need to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants