Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert puppeteer back to previous version ^13.0.0 in order to fix issue with weekly automated benchmarks update #123

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Revert puppeteer back to previous version ^13.0.0 in order to fix issue with weekly automated benchmarks update #123

merged 1 commit into from
Jul 17, 2024

Conversation

KellyWalker
Copy link
Contributor

@KellyWalker KellyWalker commented Jul 16, 2024

Revert puppeteer back to previous version ^13.0.0 in order to fix issue with weekly automated benchmarks update

Newer versions of puppeteer install chrome to a directory the github action cannot access, causing it to fail while running update_benchmarks.ts.

This effectively undoes commit f1b2d13.

The changes in the PR were made by setting the version of puppeteer in package.json to the previous version, which was working for the github action, then running yarn to update yarn.lock.

…ue with weekly automated benchmarks update

Newer versions of puppeteer install chrome to a directory the github action cannot access, causing it to fail while running update_benchmarks.ts.

This effectively undoes commit f1b2d13.
@KellyWalker
Copy link
Contributor Author

Here is the last successful run of the weekly github action "Automated benchmarks update" on pmndrs/detect-gpu:
https://github.com/pmndrs/detect-gpu/actions/runs/5844368677

It uses the code from 48edfee as of Aug. 3, 2023, prior to the change to the puppeteer version in f1b2d13 on Aug. 15, 2023.

Here is the first run that failed:
https://github.com/pmndrs/detect-gpu/actions/runs/5914430388

It uses the code from 636eb88 as of Aug. 15, 2023, subsequent to the change to the puppeteer version in f1b2d13 on Aug. 15, 2023.

Each subsequent run likewise failed, except for one that was somehow manually run about 6 months ago (it is not clear to me why it succeeded but seems likely related to the fact that it was run manually):
https://github.com/pmndrs/detect-gpu/actions/runs/7726943436

Here is the run of the same github action on the fork KellyWalker/detect-gpu
https://github.com/KellyWalker/detect-gpu/actions/runs/9962739737/job/27527192844

The action failed in the end because of a missing token to actually publish changes, but the previously failing "Update" step that runs yarn run update-benchmarks succeeded.

@KellyWalker
Copy link
Contributor Author

Other potential solutions to fix this issue include:

  • Update to the latest version of puppeteer that installs chrome to a usable directory, which I think may be 18.2.1
  • Use the version of puppeteer that caused the github action to break (or even a later one), but add the right configuration to avoid installation of chrome in its default unusable directory. That seems to be possible given some searching around.

It seems like a good idea to get things back to a working state and then potentially make one of the above changes.

@puckey puckey merged commit 04b3f14 into pmndrs:master Jul 17, 2024
@KellyWalker KellyWalker deleted the feature/kelly.walker/revert-puppeteer-update branch July 17, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants