Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Controls): adding CameraControls #1237

Merged
merged 1 commit into from
Jan 21, 2023
Merged

feat(Controls): adding CameraControls #1237

merged 1 commit into from
Jan 21, 2023

Conversation

abernier
Copy link
Member

@abernier abernier commented Jan 21, 2023

Note Merged
see <CameraControls> doc

Why

A CameraControls implementation component for drei.

See also this comment: yomotsu/camera-controls#262 (comment)

What

A drei <CameraControls /> heavily inspired by the already present <OrbitControls />

Checklist

  • Documentation updated
  • Storybook entry added
  • Ready to be merged

@vercel
Copy link

vercel bot commented Jan 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
drei ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 21, 2023 at 9:27PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b28adc7:

Sandbox Source
withered-fog-np05vn Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Member

@CodyJasonBennett CodyJasonBennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tree-shaking looks good to me here and in camera-controls. Same with types, all good here.

@CodyJasonBennett CodyJasonBennett changed the title CameraControls feat(Controls): adding CameraControls Jan 21, 2023
@CodyJasonBennett CodyJasonBennett merged commit 206f827 into pmndrs:master Jan 21, 2023
@github-actions
Copy link

🎉 This PR is included in version 9.54.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants