Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer #1250

Merged
merged 3 commits into from
Mar 13, 2023
Merged

devcontainer #1250

merged 3 commits into from
Mar 13, 2023

Conversation

abernier
Copy link
Member

@abernier abernier commented Jan 26, 2023

Note Merged
see Open Drei Codespace

Why / What

This PR aims at enhancing the developer experience, by allowing anyone to have the project up-and-running in a Codespace in one click, right from his browser:


— screencast: https://youtu.be/80ggXfZYs5k

Adding a .devcontainer that:

  • runs a linux machine (with enough memory)
  • with node 16
  • with yarn v1
  • automatically yarn install
  • starts Storybook server
  • displays Storybook preview, aside with HRM
  • pre-installs prettier and eslint extensions
  • pre-configures "format on save" setting

It also works locally with Dev Containers extension

Checklist

  • Ready to be merged

@vercel
Copy link

vercel bot commented Jan 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
drei ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 26, 2023 at 6:34PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85bc644:

Sandbox Source
compassionate-mendel-429ofw Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

Storybook likes memory
@abernier abernier changed the title chore: adding a devcontainer devcontainer Jan 26, 2023
@abernier abernier marked this pull request as ready for review January 26, 2023 18:45
@abernier abernier closed this by deleting the head repository Jan 27, 2023
@abernier abernier reopened this Jan 27, 2023
@drcmda drcmda merged commit bb2997b into pmndrs:master Mar 13, 2023
@github-actions
Copy link

🎉 This PR is included in version 9.57.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants