Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useVideoTexture): now accepting a src that is a MediaStream #1370

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

abernier
Copy link
Member

@abernier abernier commented Mar 30, 2023

Note Merged
see useVideoTexture doc

Why / What

Trying to configure useVideoTexture to also accept a mediaStream (from .getDisplayMedia()) to allow screen sharing into it.

See: https://discord.com/channels/740090768164651008/1090246938949079062/1090665612721791097

suzi-on-dplus2.mov

Checklist

  • Documentation updated
  • Storybook entry added
  • Ready to be merged

@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
drei ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 6:14PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d08fd5:

Sandbox Source
practical-orla-9ttfu3 Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@abernier abernier requested a review from drcmda March 30, 2023 11:12
@abernier abernier force-pushed the abernier/usevideotexture-mediastream branch from ea56ffe to d750c5b Compare March 30, 2023 11:23
@abernier abernier changed the title feat(useVideoTexture): now accept a src that is a MediaStream feat(useVideoTexture): now accepting a src that is a MediaStream Mar 30, 2023
@abernier abernier force-pushed the abernier/usevideotexture-mediastream branch from d750c5b to 615849d Compare March 30, 2023 17:12
@abernier abernier force-pushed the abernier/usevideotexture-mediastream branch from 615849d to 1db9850 Compare March 30, 2023 18:02
@abernier abernier force-pushed the abernier/usevideotexture-mediastream branch from 1db9850 to 0d08fd5 Compare March 30, 2023 18:12
@abernier abernier removed the request for review from drcmda March 30, 2023 18:16
@drcmda drcmda marked this pull request as ready for review March 30, 2023 18:21
@abernier abernier merged commit c95796b into master Mar 30, 2023
@github-actions
Copy link

🎉 This PR is included in version 9.60.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants