fix(Html): use transform for perspective browser issues #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 73aebf7:
|
donmccurdy
reviewed
Oct 24, 2023
| @@ -341,7 +341,7 @@ export const Html: ForwardRefComponent<HtmlProps, HTMLDivElement> = /* @__PURE__ | |||
| } | |||
| el.style.width = size.width + 'px' | |||
| el.style.height = size.height + 'px' | |||
| el.style.perspective = isOrthographicCamera ? '' : `${fov}px` | |||
| el.style.transform = isOrthographicCamera ? '' : `perspective(${fov}px)` | |||
There was a problem hiding this comment.
This will need to be the first transform on "transformOuterRef" below, rather than a transform on "el", I believe.
|
🎉 This PR is included in version 9.88.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
CodyJasonBennett
added a commit
that referenced
this pull request
Nov 16, 2023
This reverts commit d34816a.
CodyJasonBennett
added a commit
that referenced
this pull request
Nov 16, 2023
|
Hey, @drcmda, this wasn't supposed to be merged. Maybe I should have converted into a draft but I needed to investigate @donmccurdy's review further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #428, mirrors mrdoob/three.js#27017.