fix: add material parameters to SegmentsProps
#1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a2ca315:
|
|
🎉 This PR is included in version 9.88.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
Segmentscomponent currently passes on any unrecognized props to itsLineMaterial, but the type definition forSegmentsPropsdoes not allow any such parameters to be supplied.drei/src/core/Segments.tsx
Lines 8 to 12 in 1169c02
drei/src/core/Segments.tsx
Lines 81 to 88 in 1169c02
The
{...rest}spreading was presumably added for a reason, but it is currently impossible to take advantage of. I ran into this issue when attempting to create dashed segments.What
This pull request modifies the type definition of
SegmentsPropsto allowLineMaterialParametersto be passed through to the underlying line material, which I believe was the original intent.I updated README.md following the example of how other components which pass through material parameters are documented.
Checklist