fix: cache DRACOLoader instance in useGLTF #616
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/drei/6uaduYALVQiiyQrJe3P2r4RCm2cM |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 03aa8ae:
|
| dracoLoader.setDecoderPath( | ||
| typeof useDraco === 'string' ? useDraco : 'https://www.gstatic.com/draco/versioned/decoders/1.4.0/' | ||
| typeof useDraco === 'string' ? useDraco : 'https://www.gstatic.com/draco/versioned/decoders/1.4.3/' |
There was a problem hiding this comment.
just making sure, certain that 1.4.3 is ok? they broke practically everything in a recent update and i don't trust their patch updates. can we be sure this is safe?
There was a problem hiding this comment.
Great question! We were discussing this here google/draco#751
The versioned URLs are recommended and 1.4.3 is the latest.
I would expect useGLTF to pull the latest if not overriding it with my own local version 🤷♂️
|
🎉 This PR is included in version 7.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I am also getting multiple KTX loaders warning when using |
Why
Fix #615 - Multiple DRACOLoader instances are known to cause problems on iOS: mrdoob/three.js#22445
What
useGLTFChecklist