Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support for v9 configs #53

Merged
merged 6 commits into from
Nov 11, 2024
Merged

feat(core): support for v9 configs #53

merged 6 commits into from
Nov 11, 2024

Conversation

barelyhuman
Copy link
Collaborator

@barelyhuman barelyhuman commented Nov 5, 2024

Add v9 config support with backward compat for v8

  • Remove Modified API's
  • Setup CI to run tests running both v8 v9 versions
  • Decide Release to be marked as breaking or not

Closes: #50

Copy link

github-actions bot commented Nov 5, 2024

Size Change: +108 B (+2.59%)

Total Size: 4.27 kB

Filename Size Change
dist/index.js 4.27 kB +108 B (+2.59%)

compressed-size-action

@barelyhuman
Copy link
Collaborator Author

@dai-shi seems to be working, any chance you can run a local install to confirm v8 compat with one of your projects?

@dai-shi
Copy link
Member

dai-shi commented Nov 6, 2024

I don't have a good project to test. Let's see if someone can help testing.

@barelyhuman
Copy link
Collaborator Author

i tested this on a few of my projects and it seems to be working, let's get a release, I'd recommend a breaking release

@dai-shi
Copy link
Member

dai-shi commented Nov 11, 2024

v0.7.0?

@barelyhuman
Copy link
Collaborator Author

Oh right we haven't reached v1, yeah okay, v0.7.0 works.

We'll just put it in release notes that it might be breaking

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge this and release v0.7.0.

@barelyhuman barelyhuman merged commit 50aae4b into main Nov 11, 2024
11 of 12 checks passed
@barelyhuman barelyhuman deleted the feat/v9-compat branch November 11, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support eslint v9 flat config
2 participants