fix(react): avoid JSX transform for <= React 18 interop #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bff0713:
|
|
I thought it's fine as React 18 is still CJS and not a big difference, but I see "exports" is the difference. |
dai-shi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prefers to use React's classic transform
import { createElement } from 'react'to the new JSX transformimport { jsx } from 'react/jsx-runtime'which relies on use ofpackage#exportsnot present before React 18 (facebook/react#20235). In earlier versions, this would need to point toreact/jsx-runtime.js, so it's not trivial to support React 17-18 when using automatic transform in an ESM context. I'd very much prefer for this to not require the use of the React namespace since that can be lost in refactor (e.g. https://github.com/kaqiinono/babel-jsx-pragma-module-auto-import), but I'll have to defer that to someone more familiar with the library and its build system.