fix(utils/atomWithStorage): defaultStorage with disabled local storage crashes on mount #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 76afd16:
|
benediktschlager
force-pushed
the
fix/utils/atomWithStorage-crashing-when-cookies-are-disabled
branch
from
6b2b122 to
545e64e
Compare
dai-shi
requested changes
Jan 23, 2024
On Chrome, it's the same with slightly different message: |
|
@benediktschlager hi, are you still around? |
benediktschlager
force-pushed
the
fix/utils/atomWithStorage-crashing-when-cookies-are-disabled
branch
from
545e64e to
007c47f
Compare
dai-shi
reviewed
Jan 24, 2024
src/vanilla/utils/atomWithStorage.ts
Outdated
| return window.localStorage | ||
| } catch (e) { | ||
| // Window could be undefined or local storage could be disabled | ||
| if (e instanceof TypeError || e instanceof DOMException) { |
There was a problem hiding this comment.
Hmm, this is what I tried in Node.js:
> try { window.localStorage } catch (e) { console.log(e instanceof TypeError) }
false
undefined
> try { window.localStorage } catch (e) { console.log(e instanceof ReferenceError) }
true
undefined
Maybe, it's not stable. On the other hand, when is the case we want to throw e?
There was a problem hiding this comment.
Oh, it seems on node the window instance is not even defined.
I'm wondering under which circumstances the window instance is not defined, but this library is used?
As far as I understand, Jotai only works alongside React?
|
Hi @dai-shi, I included your feedback. |
dai-shi
reviewed
Jan 24, 2024
dai-shi
reviewed
Jan 24, 2024
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
|
oops, can you run prettier please? |
dai-shi
reviewed
Jan 24, 2024
dai-shi
approved these changes
Jan 24, 2024
dai-shi
changed the title
davydkov
referenced
this pull request
in likec4/likec4
Feb 7, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jotai](https://github.com/pmndrs/jotai) | [`^2.6.0` -> `^2.6.4`](https://renovatebot.com/diffs/npm/jotai/2.6.0/2.6.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/jotai (jotai)</summary> ### [`v2.6.4`](https://github.com/pmndrs/jotai/releases/tag/v2.6.4) [Compare Source](https://github.com/pmndrs/jotai/compare/v2.6.3...v2.6.4) Performance improvement! Check it out! ##### What's Changed - refactor: refactoring store and options type by [@​ssi02014](https://github.com/ssi02014) in [https://github.com/pmndrs/jotai/pull/2360](https://github.com/pmndrs/jotai/pull/2360) - refactor: modified Args type by [@​ssi02014](https://github.com/ssi02014) in [https://github.com/pmndrs/jotai/pull/2367](https://github.com/pmndrs/jotai/pull/2367) - Improve performance of recomputeDependents by [@​samkline](https://github.com/samkline) in [https://github.com/pmndrs/jotai/pull/2363](https://github.com/pmndrs/jotai/pull/2363) - fix(vanilla): fix unexpected cache in jotai-scope by [@​yf-yang](https://github.com/yf-yang) in [https://github.com/pmndrs/jotai/pull/2371](https://github.com/pmndrs/jotai/pull/2371) ##### New Contributors - [@​ssi02014](https://github.com/ssi02014) made their first contribution in [https://github.com/pmndrs/jotai/pull/2360](https://github.com/pmndrs/jotai/pull/2360) - [@​samkline](https://github.com/samkline) made their first contribution in [https://github.com/pmndrs/jotai/pull/2363](https://github.com/pmndrs/jotai/pull/2363) - [@​yf-yang](https://github.com/yf-yang) made their first contribution in [https://github.com/pmndrs/jotai/pull/2371](https://github.com/pmndrs/jotai/pull/2371) **Full Changelog**: pmndrs/jotai@v2.6.3...v2.6.4 ### [`v2.6.3`](https://github.com/pmndrs/jotai/releases/tag/v2.6.3) [Compare Source](https://github.com/pmndrs/jotai/compare/v2.6.2...v2.6.3) Some improvements in core and utils 👏 #### What's Changed - fix: atoms should not remount on recalculations (with async dependencies) by [@​dmaskasky](https://github.com/dmaskasky) in [https://github.com/pmndrs/jotai/pull/2347](https://github.com/pmndrs/jotai/pull/2347) - fix(utils): atomWithReducer for jotai-scope by [@​dai-shi](https://github.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/2351](https://github.com/pmndrs/jotai/pull/2351) - fix(utils/atomWithStorage): defaultStorage with disabled local storage crashes on mount by [@​benediktschlager](https://github.com/benediktschlager) in [https://github.com/pmndrs/jotai/pull/2354](https://github.com/pmndrs/jotai/pull/2354) - feat(vanilla): customizable atom.unstable_is by [@​dai-shi](https://github.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/2356](https://github.com/pmndrs/jotai/pull/2356) #### New Contributors - [@​SpringHgui](https://github.com/SpringHgui) made their first contribution in [https://github.com/pmndrs/jotai/pull/2320](https://github.com/pmndrs/jotai/pull/2320) - [@​sakurawen](https://github.com/sakurawen) made their first contribution in [https://github.com/pmndrs/jotai/pull/2358](https://github.com/pmndrs/jotai/pull/2358) - [@​JoltCode](https://github.com/JoltCode) made their first contribution in [https://github.com/pmndrs/jotai/pull/2357](https://github.com/pmndrs/jotai/pull/2357) - [@​benediktschlager](https://github.com/benediktschlager) made their first contribution in [https://github.com/pmndrs/jotai/pull/2354](https://github.com/pmndrs/jotai/pull/2354) **Full Changelog**: pmndrs/jotai@v2.6.2...v2.6.3 ### [`v2.6.2`](https://github.com/pmndrs/jotai/releases/tag/v2.6.2) [Compare Source](https://github.com/pmndrs/jotai/compare/v2.6.1...v2.6.2) Some improvements for atomWithStorage. Feedback is welcome. #### What's Changed - fix(vanilla): should mount once with atom creator atom by [@​nogaten](https://github.com/nogaten) in [https://github.com/pmndrs/jotai/pull/2319](https://github.com/pmndrs/jotai/pull/2319) - feat(utils): createJSONStrage options by [@​dai-shi](https://github.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/2324](https://github.com/pmndrs/jotai/pull/2324) - feat(utils): add withStorageValidator by [@​dai-shi](https://github.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/2336](https://github.com/pmndrs/jotai/pull/2336) #### New Contributors - [@​L-Qun](https://github.com/L-Qun) made their first contribution in [https://github.com/pmndrs/jotai/pull/2318](https://github.com/pmndrs/jotai/pull/2318) - [@​ahme-dev](https://github.com/ahme-dev) made their first contribution in [https://github.com/pmndrs/jotai/pull/2332](https://github.com/pmndrs/jotai/pull/2332) - [@​nogaten](https://github.com/nogaten) made their first contribution in [https://github.com/pmndrs/jotai/pull/2319](https://github.com/pmndrs/jotai/pull/2319) **Full Changelog**: pmndrs/jotai@v2.6.1...v2.6.2 ### [`v2.6.1`](https://github.com/pmndrs/jotai/releases/tag/v2.6.1) [Compare Source](https://github.com/pmndrs/jotai/compare/v2.6.0...v2.6.1) This version has two minor improvements for library authors. It's wonderful to see Jotai ecosystem growing. No major bugs have been reported lately. It's fairly okay to say the current version is pretty stable. #### What's Changed - fix(utils): add init property to the return type of atomWithReset by [@​jaesoekjjang](https://github.com/jaesoekjjang) in [https://github.com/pmndrs/jotai/pull/2304](https://github.com/pmndrs/jotai/pull/2304) - fix(utils): add description for the RESET symbol. by [@​MiroslavPetrik](https://github.com/MiroslavPetrik) in [https://github.com/pmndrs/jotai/pull/2307](https://github.com/pmndrs/jotai/pull/2307) #### New Contributors - [@​wherehows](https://github.com/wherehows) made their first contribution in [https://github.com/pmndrs/jotai/pull/2270](https://github.com/pmndrs/jotai/pull/2270) - [@​benson00077](https://github.com/benson00077) made their first contribution in [https://github.com/pmndrs/jotai/pull/2284](https://github.com/pmndrs/jotai/pull/2284) - [@​ioExpander](https://github.com/ioExpander) made their first contribution in [https://github.com/pmndrs/jotai/pull/2280](https://github.com/pmndrs/jotai/pull/2280) - [@​jaesoekjjang](https://github.com/jaesoekjjang) made their first contribution in [https://github.com/pmndrs/jotai/pull/2304](https://github.com/pmndrs/jotai/pull/2304) **Full Changelog**: pmndrs/jotai@v2.6.0...v2.6.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/likec4/likec4). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues or Discussions
Fixes downstream issue for https://ui.shadcn.com/
It crashes when cookies are disabled with this exception:
Summary
On Firefox accessing the property localStorage of window results in a
DOMException: The operation is insecure.This PR will handle this case gracefully and fall back to providing no storage implementation. This should be fine as we cannot store anything in a cookie-free browser.
Check List
yarn run prettierfor formatting code and docs