New store implementation as store2.ts
#2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Size Change: +18.3 kB (+25%) 🚨 Total Size: 90.6 kB
ℹ️ View Unchanged
|
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/4YQ4KXCEH |
See documentations for usage instructions.
|
Tagging those who might be interested: @arjunvegda @dmaskasky @backbone87 @iwoplaza |
|
I will merge this for |
iwoplaza
reviewed
Apr 3, 2024
Co-authored-by: Iwo Plaza <iwoplaza@gmail.com>
dai-shi
commented
Apr 4, 2024
| */ | ||
| readonly d: Map<AnyAtom, { readonly v: AnyValue } | { readonly e: AnyError }> | ||
| /** Set of atoms that depends on the atom. */ | ||
| readonly t: Set<AnyAtom> |
There was a problem hiding this comment.
As this holds a strong reference, it may cause memory leaks.
We should create a failing test case and fix it. (Probably by moving it to Mounted, or possibly with WeakRef but unlikely.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current store implementation is based on the assumption I made in Jotai v1. Since then, it has changed and v2 design is slightly different. Technically speaking, in v1, we tried to support state branching (or state versioning) which we gave up in v2. So, the store implementation could be a little simpler. This PR introduces a new implementation with mutable atom state. Currently, we have a new
store2.tsfile and run tests to bothstore.tsandstore2.ts. We hope to replacestore.tswithstore2.tseventually. This is not the end, but the start. We might be able to simplify the new implementation and add some new capabilities. But, for now, the migration is important especially with/for jotai-devtools. It takes time.