-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(utils): atomFamily supports getParams and unstable_listen api #2685
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Preview in LiveCodesLatest commit: 48ed9fa
See documentations for usage instructions. |
a28dde4
to
3c4b479
Compare
3c4b479
to
cdb5f25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Added a few comments.
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
Ready to merge. |
Related Bug Reports or Discussions
Past ideas
idea1: #2678
idea2: #2679
idea3: #2681
idea4: #2683
Fixes #2056
Fixes jotaijs/jotai-scope#50
Summary
jotai-scope is trying to support scoping atomFamily.
This PR demonstrates one approach in which the atomFamily supports
getParams
andunstable_listen
.The following pseudo code represents logic that would live in jotai-scope.
Check List
pnpm run prettier
for formatting code and docs