Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: calculate coverage for src files only #2786

Merged

Conversation

kretajak
Copy link
Contributor

@kretajak kretajak commented Oct 26, 2024

Summary

Code coverage should rather take into account files from src. Files from folders like benchmark, examples or website should not be taken into account when evaluating coverage.

Quote from Vitest

It's recommended to always define coverage.include in your configuration file. This helps Vitest to reduce the amount of files picked by coverage.all.

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 10:49pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@dai-shi
Copy link
Member

dai-shi commented Oct 27, 2024

Can you apply the same change to zustand and valtio please?

Copy link

LiveCodes Preview in LiveCodes

Latest commit: 5c4b290
Last updated: Oct 26, 2024 10:48pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/8ME9AEUFP

See documentations for usage instructions.

@kretajak
Copy link
Contributor Author

Can you apply the same change to zustand and valtio please?

Sure: pmndrs/zustand#2822 and pmndrs/valtio#984.

@dai-shi
Copy link
Member

dai-shi commented Oct 28, 2024

Thanks so much!

@dai-shi dai-shi merged commit 551a4a5 into pmndrs:main Oct 28, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants