Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useAtomsDevtools: Show all atoms updated by a write #943

Closed
wants to merge 3 commits into from

Conversation

justjake
Copy link
Contributor

@justjake justjake commented Jan 9, 2022

Draft PR to address one idea in #931.

The idea of this PR is to records all the atoms changed during an atom write into an event, and then uses that event data to enhance redux devtools.

I think I need to propagate the write event through all codepaths that call flushPending.

Here's a screenshot of the goal:

image

for this example component:

image

@vercel
Copy link

vercel bot commented Jan 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/EnXBomWGfqUWoW8WvXew9PyRCMwt
✅ Preview: https://jotai-git-fork-justjake-devtools-grouping-pr-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2e93842:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@dai-shi
Copy link
Member

dai-shi commented Dec 1, 2022

Closing this for now. Let's continue discussion in #931.

@dai-shi dai-shi closed this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants