copies by reference instead of reconstructing the whole tuple #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
since we only use the tuple in two places, where one of the two places uses the copy i've made the copy use reference instead of reconstructing the whole tuple since that's not necessary.
|
|
Thanks for the PR! 🙂 LGTM, I'll merge & release shortly. |
|
@issy123 I see you've got an open PR in the original repo: schteppe#366 Are there other improvements in that PR that you think should be brought over? |
|
No not really tbh most of my changes were bullshit |
|
Haha, no worries then :) thanks again for this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.