Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-release #194

Merged
merged 2 commits into from
May 1, 2023
Merged

semantic-release #194

merged 2 commits into from
May 1, 2023

Conversation

abernier
Copy link
Member

@abernier abernier commented May 1, 2023

"kill all humans"
— Bender

@talentlessguy
Copy link
Member

why reset the version?

@abernier abernier force-pushed the abernier/semantic-release branch from ba431f9 to fab7474 Compare May 1, 2023 10:16
@abernier
Copy link
Member Author

abernier commented May 1, 2023

why reset the version?

Semantic release takes care of updating the version just before publishing to NPM. There is no need to have it versioned in source code. Thanks to semantic-release, the version will already appear as the latest release:
image

This is also how it's done in drei and explained in more details here: https://semantic-release.gitbook.io/semantic-release/support/faq#why-is-the-package.jsons-version-not-updated-in-my-repository

.node-version Show resolved Hide resolved
@abernier
Copy link
Member Author

abernier commented May 1, 2023

I think I'm done.

We could safely merge it into master: it won't trigger a release since only chore: commit messages in this PR (only feat: or fix: will).

Once merged, we could check the new Build and Release to npm pipeline just succeeds (without publishing any new version)

@drcmda drcmda merged commit 3a9998a into master May 1, 2023
@drcmda
Copy link
Member

drcmda commented May 1, 2023

thanks @abernier !

@talentlessguy talentlessguy deleted the abernier/semantic-release branch May 1, 2023 11:09
@github-actions
Copy link

github-actions bot commented May 1, 2023

🎉 This PR is included in version 2.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants