fix(types): ensure instanceprops override nodeprops

pmndrs · Aug 31, 2022 · 1104c5b · 1104c5b
1 parent 903392e
commit 1104c5b
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/fiber/src/three-types.ts b/packages/fiber/src/three-types.ts
@@ -36,10 +36,11 @@ interface ReactProps<P> {
   key?: React.Key
 }
 
-type NodeProps<T extends Function, P = T['prototype']> = Omit<InstanceProps<T>, 'object'> &
-  Partial<ReactProps<P> & MathProps<P> & EventProps<P>>
+type NodeProps<T extends Function, P = T['prototype']> = Partial<ReactProps<P> & MathProps<P> & EventProps<P>>
 
-export type Node<T extends Function> = Mutable<Overwrite<Partial<WithoutFunctions<T['prototype']>>, NodeProps<T>>>
+export type Node<T extends Function> = Mutable<
+  Overwrite<Partial<WithoutFunctions<T['prototype']>>, Overwrite<NodeProps<T>, Omit<InstanceProps<T>, 'object'>>>
+>
 
 type ThreeExports = typeof THREE
 type ThreeElementsImpl = {