fix: skip scene children

pmndrs · Nov 6, 2023 · 8aa5c6e · 8aa5c6e
1 parent d3ad408
commit 8aa5c6e
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/fiber/src/core/utils.ts b/packages/fiber/src/core/utils.ts
@@ -176,7 +176,11 @@ export function buildGraph(object: THREE.Object3D) {
 // Disposes an object and all its properties
 export function dispose<TObj extends { dispose?: () => void; type?: string; [key: string]: any }>(obj: TObj) {
   if (obj.dispose && obj.type !== 'Scene') obj.dispose()
-  for (const key in obj) obj[key].dispose?.()
+  for (const key in obj) {
+    const value = obj[key]
+    if (value.type === 'Scene') continue
+    value.dispose?.()
+  }
 }
 
 // Each object in the scene carries a small LocalState descriptor