fix(core):cannot remove effects correctly when use addEffect/addAfter… #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1d671c0:
|
drcmda
reviewed
Jul 5, 2022
| subs.push(callback) | ||
| return () => void subs.splice(index, 1) | ||
| function createSubs(callback: GlobalRenderCallback, subs: Set<SubItem>): () => void { | ||
| const sub = {callback} |
There was a problem hiding this comment.
looks good i think we should use set, but just that, why do you wrap it into an object here?
There was a problem hiding this comment.
If don't use object to wrap the callback, pass in the identical callback function more than once and will only one is left.
for example just like the below.
const log = (ts) = console.log('log', ts);
addEffect(log);
addEffect(log);
addEffect(log);If so, it will confuse the developers.
sincerely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when use addEffect/addAfterEffect/addTail, cannot remove effects(subscriptions) correctly.
I use Set instead of Array to fix this problem.
thanks for Creating a such perfect project.
sincerely