Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests typecheck #2375

Merged
merged 9 commits into from
Jul 25, 2022
Merged

fix: tests typecheck #2375

merged 9 commits into from
Jul 25, 2022

Conversation

bart-krakowski
Copy link
Contributor

@bart-krakowski bart-krakowski commented Jul 19, 2022 •
edited
Loading

This PR corrects several typing errors and removes ts-ignore from test files.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 19, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 69db212:

Sandbox Source
example Configuration

joshuaellis
joshuaellis requested changes Jul 19, 2022
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot more additional context as to why you've made the choices is necessary before merging. Especially since you've edited the tsconfig for the project.

joshuaellis
joshuaellis approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this, @CodyJasonBennett?

@CodyJasonBennett CodyJasonBennett merged commit e2baeaa into pmndrs:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

@CodyJasonBennett CodyJasonBennett Awaiting requested review from CodyJasonBennett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bart-krakowski @CodyJasonBennett @joshuaellis