Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle primitive children on reconstruct #2452

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

CodyJasonBennett
Copy link
Member

@CodyJasonBennett CodyJasonBennett commented Aug 21, 2022

Swaps over R3F-managed children of primitives when reconstructing. This lets their object prop predictably keep declarative children.

<primitive object={foo ? object1 : object2}>
  <mesh />
  <material />
</primitive>

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6186465:

Sandbox Source
example Configuration

@CodyJasonBennett CodyJasonBennett merged commit 00e6f64 into master Aug 21, 2022
@CodyJasonBennett CodyJasonBennett deleted the fix/primitive-children-reconstruct branch August 21, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant