[v9] fix: handle container effects on completed trees, track instance visibility #2483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2465, fixes #2250.
Moves
attach
and interactivity tohandleContainerEffects
which will fire when trees are linked and finalized. This ensures that effects are not duplicated due to suspense and complete outside of commit, so we're never late and present an incomplete tree.I've updated the CSB to highlight the intricacies throughout the reconciler lifecycle: https://codesandbox.io/s/scrgbc. Should fire
attach
(uuid must match ref and thus be current),useLayoutEffect
(ensures the view is completed before presenting), then the parent is reconstructed from scratch so children willdetach
andattach
.I've also added an
isHidden
property to instances to make sure we don't handleattach
ordetach
for instances that weren't hidden by React. This could similarly cause duplication.