fix(types): don't overwrite types of infer fallback

[CodyJasonBennett]

Addresses some type regressions with {} and children investigated in #2668.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c3f541f:

Sandbox	Source
example	Configuration

[krispya]

This fixes my issue.

[krispya]

Not to celebrate too soon, the nested instrinsics are giving me the error Type 'Element' is not assignable to type 'Object3D<Event> | (string & Object3D<Event>)'

For example:

 <mesh>
        <planeGeometry />
        <meshBasicMaterial>
          {children}
        </meshBasicMaterial>
      </mesh>

[CodyJasonBennett]

Yeah, there's a myriad of issues going on here. If I can figure out how to narrow keys into a union that extend a type, I can fix it.

[CodyJasonBennett]

b657651 works for now.

I'd like WithMathProps to instead only map keys that extend the "math" signature as per my previous comment (and be renamed MathProps), but I haven't any luck. That'll also help clamp down noise from non-classes in ThreeElements that are just never. Referencing https://www.typescriptlang.org/docs/handbook/2/mapped-types.html#key-remapping-via-as.

type MathTypes = THREE.Color | MathRepresentation | VectorRepresentation
type MathKeys<P> = { [K in keyof P]-?: P[K] extends MathTypes ? never : K }[keyof P]

type MathType<M> = M extends THREE.Color
  ? ConstructorParameters<typeof THREE.Color> | THREE.ColorRepresentation
  : M extends MathRepresentation
  ? M extends VectorRepresentation
    ? M | Parameters<M['set']> | Parameters<M['setScalar']>[0]
    : M | Parameters<M['set']>
  : {}

type MathProps<P> = {
  [K in MathKeys<P>]: MathType<P[K]>
}

[krispya]

Thanks Cody. I can confirm this fixed the issues I was having. Drei's type issues dropped by a significant amount too.

[CodyJasonBennett]

Cool, if you can update the issue with a txt or snapshot that would help with withstanding issues.