Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] experiment(types): ThreeElements extends interface extends mapped type #2722

Closed
wants to merge 1 commit into from

Conversation

CodyJasonBennett
Copy link
Member

Tries to address an issue in #2668 (comment) where writing into ThreeElements completely overwrites it.

declare module '@react-three/fiber' {
  interface ThreeElements {
    element: ThreeElement<typeof Element>
  }
}

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 09eb560:

Sandbox Source
example Configuration

@krispya
Copy link
Member

krispya commented Feb 27, 2023

This isn't required as long as the project has an up-to-date version of TypeScript: #2668 (comment)

@CodyJasonBennett CodyJasonBennett deleted the experiment/types-extend-interface branch February 27, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants