fix: recursively dispose of properties #3088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5a3d453:
|
CodyJasonBennett
commented
Nov 6, 2023
Comment on lines
-179
to
+182
| for (const p in obj) { | ||
| ;(p as any).dispose?.() | ||
| delete obj[p] | ||
| for (const key in obj) { | ||
| const value = obj[key] | ||
| if (value?.dispose && value.type !== 'Scene') value.dispose?.() | ||
| // delete obj[key] |
There was a problem hiding this comment.
This didn't work in the first place @drcmda. p was a key or string type.
|
Moving this to v9. Will backport if able. Need to do more memory testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3087. Ensures that properties are properly disposed as well.