-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make textinstance no-op instead of warn #3366
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 213d2c3:
|
You can run your changes against the examples by running Heres more info on building/testing: https://github.com/pmndrs/react-three-fiber/blob/master/CONTRIBUTING.md |
@DennisSmolek Thank you a lot! Printing the text definitely works (I've added a fragment: But I struggle to pass the property to the renderer. We might want to only print the text. |
Perhaps we should only no-op here. We can't make warnings or errors useful without tracing, and I have not found a reliable way to obtain this. |
no-op would make sense because we do not expect text to be drawn without a proper component in a r3f canvas if ok for you i can update the PR |
cbf5c2f
to
213d2c3
Compare
@CodyJasonBennett I have just updated the PR to make handleTextInstance no-op (super light PR...) |
This PR aims to implement the behavior described in #3302
I did not achieve to test it on a local project (even though I succeeded a few months ago). Do you have some documentation to provide to compile and test on a project?