fix: ThreeEvent should not include initMouseEvent #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c678771:
|
|
Nice find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the types for all onClick, ... events expose the
initMouseEventfunction. ThePropertiestype definition has the goal to remove all functions, but it only removes functions with one parameter. Therefore theinitMouseEventis not removed and the type is forwarded to the event, even though noinitMouseEventfunction exists on the actual event object.This PR fixes that and uses a more modern way of filtering entries in the map using
assupported from typescript 4.1 (4 years ago). https://www.typescriptlang.org/docs/handbook/2/mapped-types.html#key-remapping-via-as